Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for a tree(skip) field attribute #183

Merged
merged 5 commits into from
Oct 12, 2023
Merged

Conversation

ryan-summers
Copy link
Member

Adds support for skipping fields in a miniconf tree.

Fixes #182

@ryan-summers ryan-summers requested a review from jordens October 12, 2023 11:55
@ryan-summers
Copy link
Member Author

Thanks for the cleanup - the refactor to an Option on new() was what I was contemplating as well. I like the approach :)

Copy link
Member

@jordens jordens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryan-summers I made a couple tweaks.

@ryan-summers
Copy link
Member Author

ryan-summers commented Oct 12, 2023

@jordens We seem to be hitting a ton of ICEs (Internal Compiler Errors) when compiling on stable for some reason... I don't see these locally with my rustc 1.72.0

@jordens
Copy link
Member

jordens commented Oct 12, 2023

rust-lang/rust#116662

@jordens jordens merged commit 587a5bf into main Oct 12, 2023
9 of 16 checks passed
@jordens jordens deleted the feature/skip-support branch October 12, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add #[tree(skip)]
2 participants