Repository navigation
test(website): compare docs and editor screenshots before and after deployment - #5035
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Benchmark for 8addc3eClick to view benchmark
|
benfdking
force-pushed
the
test/docs-theme-assets
branch
from
October 7, 2026 13:46
9aad2e7 to
c0838e7
Compare
Contributor
Benchmark for 6501bb3Click to view benchmark
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the docs theme asset fix in #5034, which is now merged. This PR targets
mainand contains the regression tests and their build/deployment wiring.The documentation build check only verifies HTML and the search index, so missing theme assets can reach GitHub Pages. Compare the docs overview, installation page, and playground editor with committed screenshot baselines. Keep the checks for successful theme CSS/JavaScript responses and editing SQL with updated formatted output.
//playground:website_testtests the combined deployment artifact and is included inbazel test //...and the pre-deployment checks.//playground:deployed_website_testruns the same suite againsthttps://playground.quary.dev, without rebuilding the website. A separateverify-deploymentjob depends on successful deployment and runs this target with--nocache_test_results. Its manual tag excludes it from wildcard test runs.Validation:
https://playground.quary.devafter the docs fix deployment.git diff --checkpass.For an intentional visual update, regenerate on each supported platform, review the changed PNGs, and commit them: