Repository navigation
Conversation
Update Tantivy to main revision e988ecb7, implement block-aware seek and exact-hit seek_danger, and return the stored hit count directly. Add coverage for iteration, seeking, and counting.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
trinity-1686a
approved these changes
Oct 19, 2026
| debug_assert!(self.doc() <= target); | ||
| while self.current_block[BitPacker1x::BLOCK_LEN - 1] < target { | ||
| self.load_new_block(); | ||
| self.block_pos = 0; |
Contributor
There was a problem hiding this comment.
nit: all callers to load_new_block() follow with self.block_pos = 0;, that should probably be moved in the function directly
Collaborator
Author
There was a problem hiding this comment.
I think we need a different format for the HitSet.
There is no skip information, which means the delta is large, which is bad for compression and seek is much slower than it should be
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
HitSet::seekandseek_dangerto skip blocks and search within the current block.e988ecb7a11109d89f9f4582b386089fc3a2fec0.How was this PR tested?
Adds tests for seeking,
seek_dangermisses, counting without consuming hits, block boundaries, and termination.make fmtpassed.cargo check -p quickwit-querypassed.cargo nextest run --locked -p quickwit-query test_hit_set: 5 passed.cargo nextest run --locked -p quickwit-query: 188 passed.