Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 [New chapter] R coding style #216

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

SaranjeetKaur
Copy link
Collaborator

Closes #133

This PR adds a new chapter on R coding style.

@SaranjeetKaur SaranjeetKaur requested a review from hturner December 4, 2024 12:39
@SaranjeetKaur SaranjeetKaur changed the title [New chapter] R coding style 📝 [New chapter] R coding style Dec 4, 2024
@SaranjeetKaur
Copy link
Collaborator Author

Also tagging @jyoti-bhogal for a review as she was interested in this issue.

Copy link
Member

@hturner hturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest adding this as a section in the lifecycle of a patch chapter instead. Reorder sections as follows:

  • When do you submit a patch?
  • Coding style
  • Making good patches
  • What tools are required to submit a patch?
  • How to prepare a patch?

- Use `TRUE` and `FALSE`, not `T` and `F`.
- Keep lines no longer than 80 characters.
- Avoid using special characters in file names (numbers, letters, `-`, and `_` are acceptable).
- Put a space after (not before) a comma.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already have this as second point

Suggested change
- Put a space after (not before) a comma.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document coding style used by R Core
2 participants