Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Testing chapter #73

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Create Testing chapter #73

wants to merge 14 commits into from

Conversation

SaranjeetKaur
Copy link
Collaborator

@SaranjeetKaur SaranjeetKaur commented Sep 21, 2022 •
edited
Loading

@SaranjeetKaur SaranjeetKaur changed the title Create Testing chapter [WIP] Create Testing chapter Sep 21, 2022
@SaranjeetKaur SaranjeetKaur added the gsod-2022 Google Season of Docs related task label Sep 21, 2022
hturner
hturner reviewed Sep 28, 2022
View reviewed changes
Copy link
Member

@hturner hturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial feedback to help your WIP

testing_in_R.Rmd Outdated Show resolved Hide resolved
testing_in_R.Rmd Outdated Show resolved Hide resolved
testing_in_R.Rmd Outdated Show resolved Hide resolved
@SaranjeetKaur SaranjeetKaur changed the title [WIP] Create Testing chapter Create Testing chapter Oct 20, 2022
@SaranjeetKaur SaranjeetKaur marked this pull request as ready for review October 20, 2022 12:33
hturner
hturner reviewed Nov 15, 2022
View reviewed changes
Copy link
Member

@hturner hturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This chapter needs to focus more on the tests specific to base R, see my detailed comments.

08-testing_in_R.Rmd Outdated Show resolved Hide resolved
08-testing_in_R.Rmd Outdated Show resolved Hide resolved
08-testing_in_R.Rmd Outdated Show resolved Hide resolved
08-testing_in_R.Rmd Outdated Show resolved Hide resolved
08-testing_in_R.Rmd Outdated Show resolved Hide resolved
08-testing_in_R.Rmd Outdated Show resolved Hide resolved
08-testing_in_R.Rmd Outdated Show resolved Hide resolved
08-testing_in_R.Rmd Outdated Show resolved Hide resolved
08-testing_in_R.Rmd Outdated Show resolved Hide resolved
@SaranjeetKaur @hturner
minor edits
386646b 
Co-authored-by: Heather Turner <[email protected]>
@willingc
Copy link
Contributor

@SaranjeetKaur Would you like to pick this PR up or close it given other changes that you have made?

@hturner hturner mentioned this pull request Dec 3, 2024
Open
hturner
hturner reviewed Dec 3, 2024
View reviewed changes
Copy link
Member

@hturner hturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've gone through to suggest some specific changes based on my review. This probably also needs bringing up to date to reflect the change in chapter numbering.

08-testing_in_R.Rmd Outdated Show resolved Hide resolved
08-testing_in_R.Rmd Outdated Show resolved Hide resolved
08-testing_in_R.Rmd Outdated Show resolved Hide resolved
08-testing_in_R.Rmd Outdated Show resolved Hide resolved
08-testing_in_R.Rmd Outdated Show resolved Hide resolved
08-testing_in_R.Rmd Outdated Show resolved Hide resolved
08-testing_in_R.Rmd Outdated Show resolved Hide resolved
08-testing_in_R.Rmd Outdated Show resolved Hide resolved
08-testing_in_R.Rmd Outdated Show resolved Hide resolved
08-testing_in_R.Rmd Outdated Show resolved Hide resolved
SaranjeetKaur and others added 2 commits December 3, 2024 14:14
SaranjeetKaur
SaranjeetKaur commented Dec 3, 2024
View reviewed changes
08-testing_in_R.Rmd Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hturner hturner hturner left review comments

Assignees
No one assigned
Labels
gsod-2022 Google Season of Docs related task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SaranjeetKaur @willingc @hturner