Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #471.
file_chmod(character(0), "644")errored with "subscript out of bounds": with no paths, the current permissions vector is empty, and the mode recycling inas_fs_perms()divides by its length.file_chmod()now returns the empty path vector invisibly when there are no paths, the same kind of zero-length guardpath_ext()uses. Recycling of modes over several paths is unchanged.This only covers the empty-path case. The other cases in the issue (a non-empty path with an empty mode, and a single path with several modes) are about what the error or behavior should be, so I left them for a separate change. I didn't add a NEWS entry since there's no development section yet.