Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename test #1282

Merged
merged 2 commits into from
Jan 1, 2025
Merged

Rename test #1282

merged 2 commits into from
Jan 1, 2025

Conversation

aidanharan
Copy link
Contributor

@aidanharan aidanharan commented Jan 1, 2025

Fix:

https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/actions/runs/12541738225/job/34970653846#step:4:486

1) Error:
SchemaDumperTest#test_dump_schema_information_outputs_lexically_reverse_ordered_versions_regardless_of_database_order_coerced:
NoMethodError: undefined method `dump_schema_information' for an instance of ActiveRecord::ConnectionAdapters::SQLServerAdapter
    test/cases/coerced_tests.rb:1579:in `test_dump_schema_information_outputs_lexically_reverse_ordered_versions_regardless_of_database_order_coerced'

  2) Failure:
SchemaDumperTest#test_dump_schema_versions_outputs_lexically_reverse_ordered_versions_regardless_of_database_order [/usr/local/bundle/bundler/gems/rails-92b3160dd65f/activerecord/test/cases/schema_dumper_test.rb:40]:
--- expected
+++ actual
@@ -1,4 +1,4 @@
 "INSERT INTO [schema_migrations] (version) VALUES
-('20100301010101'),
-('20100201010101'),
-('20100101010101');"
+(N'20100301010101'),
+(N'20100201010101'),
+(N'20100101010101');"

@aidanharan aidanharan marked this pull request as ready for review January 1, 2025 20:41
@aidanharan aidanharan merged commit 4196d90 into main Jan 1, 2025
4 checks passed
@aidanharan aidanharan deleted the fix-schema-dumper-test branch January 1, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant