Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : adds metadata filtering #48

Merged
merged 1 commit into from
May 10, 2024
Merged

feat : adds metadata filtering #48

merged 1 commit into from
May 10, 2024

Conversation

rajadilipkolli
Copy link
Owner

No description provided.

@rajadilipkolli rajadilipkolli self-assigned this May 10, 2024
Copy link
Contributor

coderabbitai bot commented May 10, 2024

Walkthrough

The recent updates across several Java files primarily enhance functionality by integrating user metadata and refining API responses. Key changes include the addition of user IDs in text segments, the introduction of optional user parameters in query methods, and the use of advanced filtering techniques in embedding search methods. Additionally, there's a new configuration for managing date functions and a modification in chat settings in the AI services.

Changes

Files Changes
.../config/Initializer.java, .../config/SwaggerConfig.java Import and annotation adjustments. Metadata added to text segments.
.../controller/QueryController.java, .../service/PgVectorStoreService.java, .../service/CustomerSupportService.java Enhanced query methods with optional userId and advanced search functionalities using new classes.
.../test/java/.../TestQueryController.java New test methods for querying with and without metadata.
.../llmragwithspringai/config/FunctionConfiguration.java, .../llmragwithspringai/service/AIChatService.java, .../llmragwithspringai/resources/application.properties Configuration and service changes for AI chat functionalities and properties adjustment.

🐇✨
In the code's garden, changes bloom bright,
Metadata and queries dance in the light.
Each line a step, each function a leap,
Through fields of Java, our updates sweep.
Cheers to the coders, with each clever tweak! 🌼🚀
🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 03abbc7 and d4b8895.
Files selected for processing (9)
  • embeddingstores/pgvector-langchain4j/src/main/java/com/learning/ai/config/Initializer.java (2 hunks)
  • embeddingstores/pgvector-langchain4j/src/main/java/com/learning/ai/config/SwaggerConfig.java (1 hunks)
  • embeddingstores/pgvector-langchain4j/src/main/java/com/learning/ai/controller/QueryController.java (1 hunks)
  • embeddingstores/pgvector-langchain4j/src/main/java/com/learning/ai/service/PgVectorStoreService.java (2 hunks)
  • embeddingstores/pgvector-langchain4j/src/test/java/com/learning/ai/controller/TestQueryController.java (1 hunks)
  • rag/rag-langchain4j-AllMiniLmL6V2-llm/src/main/java/com/learning/ai/service/CustomerSupportService.java (2 hunks)
  • rag/rag-springai-openai-llm/src/main/java/com/learning/ai/llmragwithspringai/config/FunctionConfiguration.java (1 hunks)
  • rag/rag-springai-openai-llm/src/main/java/com/learning/ai/llmragwithspringai/service/AIChatService.java (2 hunks)
  • rag/rag-springai-openai-llm/src/main/resources/application.properties (1 hunks)
Files skipped from review due to trivial changes (2)
  • embeddingstores/pgvector-langchain4j/src/main/java/com/learning/ai/config/SwaggerConfig.java
  • rag/rag-springai-openai-llm/src/main/resources/application.properties
Additional comments not posted (7)
rag/rag-springai-openai-llm/src/main/java/com/learning/ai/llmragwithspringai/config/FunctionConfiguration.java (1)

16-21: The implementation of currentDateFunction is concise and correctly utilizes Spring's @Bean annotation. Good use of logging for traceability.

embeddingstores/pgvector-langchain4j/src/main/java/com/learning/ai/controller/QueryController.java (1)

21-22: The updated signature of queryEmbeddedStore to include an optional userId parameter enhances user-specific query capabilities. Well-integrated change.

embeddingstores/pgvector-langchain4j/src/main/java/com/learning/ai/config/Initializer.java (1)

24-31: The inclusion of user-specific metadata in TextSegment instances aligns with the PR's objectives of enhancing metadata handling. The implementation is correct and clear.

embeddingstores/pgvector-langchain4j/src/test/java/com/learning/ai/controller/TestQueryController.java (1)

16-37: The test methods added are comprehensive and correctly validate the new functionalities related to user-specific queries. Good use of @Disabled for known issues awaiting fixes.

rag/rag-langchain4j-AllMiniLmL6V2-llm/src/main/java/com/learning/ai/service/CustomerSupportService.java (1)

32-37: The refactoring of the chat method to use EmbeddingSearchRequest and EmbeddingSearchResult enhances the modularity and scalability of the service. Correctly implemented.

embeddingstores/pgvector-langchain4j/src/main/java/com/learning/ai/service/PgVectorStoreService.java (1)

30-45: The enhancements to queryEmbeddingStore to include user-specific filtering using MetadataFilterBuilder are well-implemented and align with the PR's objectives of improving metadata handling.

rag/rag-springai-openai-llm/src/main/java/com/learning/ai/llmragwithspringai/service/AIChatService.java (1)

58-60: The integration of OpenAiChatOptions to dynamically specify options during prompt creation in the chat method enhances the configurability and adaptability of the AI service. Well-implemented change.

@rajadilipkolli rajadilipkolli merged commit d9a1d41 into main May 10, 2024
4 checks passed
@rajadilipkolli rajadilipkolli deleted the metadata-filtering branch May 10, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant