Mark downloads without preparedIds as PREPARING not RESTORING #40 #43
Conversation
| Response response = adminResource.setDownloadStatus(testDownload.getId(), facilityName, adminSessionId, DownloadStatus.RESTORING.toString()); | ||
| assertEquals(200, response.getStatus()); | ||
|
|
||
| response = adminResource.getDownloads(facilityName, adminSessionId, "1 = 1"); |
There was a problem hiding this comment.
Can a value of null be passed for the queryOffset? I was confused at first as to what the "1 = 1" was for but found it in other tests with a comment, so if null doesn't work, then at least a comment as to what it's for would be useful here.
There was a problem hiding this comment.
I based the test on the other existing tests which used "1 = 1", taking the comment on faith (but not copying it across to the new test). Having had a look though it seems like the code should handle null values - these tests still passed for me locally without it so I've removed it in all three places. Maybe it didn't used to work, the comments were written, then the null case handling was added but the tests were never updated? In any case hopefully they are all simpler now.
Closes #40