Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes from adding authentication to object-storage-api #408

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

joelvdavies
Copy link
Collaborator

@joelvdavies joelvdavies commented Oct 28, 2024

Description

Applies same changes made in ral-facilities/object-storage-api#58. Once #377 is done we should be able to remove the outer most conftest.py.

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.87%. Comparing base (7b89d00) to head (a13522a).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #408   +/-   ##
========================================
  Coverage    97.87%   97.87%           
========================================
  Files           41       41           
  Lines         1504     1504           
========================================
  Hits          1472     1472           
  Misses          32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joelvdavies joelvdavies requested a review from VKTB October 28, 2024 14:37
@joelvdavies joelvdavies marked this pull request as ready for review October 28, 2024 14:37
@joelvdavies joelvdavies merged commit f817718 into develop Nov 4, 2024
8 checks passed
@joelvdavies joelvdavies deleted the changes-from-object-storage-api-auth branch November 4, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants