Delete manufacturer by id #64 #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR supersedes #75. Comments there should be resolved when they get addressed, |
joelvdavies
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
Comments from #75 have been addressed in #85. I have tested this PR with ral-facilities/inventory-management-system#113 on the front end, which works so I think its also safe to merge this pending Viktor's approval provided this is merged at the same time.
3 tasks
|
|
VKTB
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Delete a manufacturer logic. Enables you to delete a manufacturer by its ID. Manufacturers who are a part of a catalogue item cannot be deleted and appropriate error message is displayed to the user
Testing instructions
Agile board tracking
closes #64