Apply suggestions from code review

Co-authored-by: Joel Davies <[email protected]>
ral-facilities · Oct 19, 2023 · b579c9b · b579c9b
1 parent 13feeba
commit b579c9b
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/cypress/e2e/catalogue/catalogueItems.cy.ts b/cypress/e2e/catalogue/catalogueItems.cy.ts
@@ -240,7 +240,7 @@ describe('Catalogue Items', () => {
     });
   });
 
-  it('displays error message if not of the field have been edited', () => {
+  it('displays error message if none of the fields have been edited', () => {
     cy.visit(
       '/inventory-management-system/catalogue/beam-characterization/energy-meters'
     );

diff --git a/src/catalogue/items/catalogueItemsDialog.component.test.tsx b/src/catalogue/items/catalogueItemsDialog.component.test.tsx
@@ -349,7 +349,7 @@ describe('Catalogue Items Dialog', () => {
       expect(onClose).toHaveBeenCalled();
     });
 
-    it('display error message when invalid number format', async () => {
+    it('display error message when invalid number format in property values and invalid manufacturer url', async () => {
       props = {
         ...props,
         parentId: '4',

diff --git a/src/catalogue/items/catalogueItemsLandingPage.component.test.tsx b/src/catalogue/items/catalogueItemsLandingPage.component.test.tsx
@@ -95,7 +95,7 @@ describe('Catalogue Items Landing Page', () => {
     });
   });
 
-  it('opens the edit catalogue item dialog', async () => {
+  it('opens and closes the edit catalogue item dialog', async () => {
     createView('/inventory-management-system/catalogue/items/1');
 
     await waitFor(() => {