Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View systems #18 #115

Merged
merged 18 commits into from
Nov 10, 2023
Merged

View systems #18 #115

merged 18 commits into from
Nov 10, 2023

Conversation

joelvdavies
Copy link
Collaborator

@joelvdavies joelvdavies commented Nov 1, 2023

Description

Adds navigation, progress bars and displays information about the selected system
e.g.

image

Where things are optional, they just display None when not defined. Also made a task for #116.

The create dialog's importance drop down has also been modified to display chips similarly.

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage
  • {more steps here}

Agile board tracking

Closes #18

@joelvdavies joelvdavies added the enhancement Improved or refactored feature label Nov 1, 2023
@joelvdavies joelvdavies self-assigned this Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d29aadf) 90.53% compared to head (9d9df42) 90.80%.

Additional details and impacted files
@@                    Coverage Diff                     @@
##           add-systems-create-#15     #115      +/-   ##
==========================================================
+ Coverage                   90.53%   90.80%   +0.27%     
==========================================================
  Files                          35       36       +1     
  Lines                        1944     1991      +47     
  Branches                      555      579      +24     
==========================================================
+ Hits                         1760     1808      +48     
+ Misses                        181      180       -1     
  Partials                        3        3              
Files Coverage Δ
src/mocks/handlers.ts 91.66% <100.00%> (+0.25%) ⬆️
src/systems/systemDetails.component.tsx 100.00% <100.00%> (ø)
src/systems/systemDialog.component.tsx 100.00% <ø> (ø)
src/systems/systems.component.tsx 100.00% <100.00%> (+8.33%) ⬆️
src/api/systems.tsx 88.73% <95.65%> (+3.31%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joelvdavies joelvdavies marked this pull request as ready for review November 2, 2023 11:53
joshuadkitenge
joshuadkitenge previously approved these changes Nov 9, 2023
Base automatically changed from add-systems-create-#15 to develop November 10, 2023 08:23
@joelvdavies joelvdavies dismissed joshuadkitenge’s stale review November 10, 2023 08:23

The base branch was changed.

@joshuadkitenge joshuadkitenge self-requested a review November 10, 2023 09:00
@joelvdavies joelvdavies merged commit 6ce62a5 into develop Nov 10, 2023
3 checks passed
@joelvdavies joelvdavies deleted the view-systems-#18 branch November 10, 2023 09:01
This was referenced Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improved or refactored feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As an end-user/operator/admin, I want to be able to view systems
2 participants