-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
View systems #18 #115
Merged
Merged
View systems #18 #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## add-systems-create-#15 #115 +/- ##
==========================================================
+ Coverage 90.53% 90.80% +0.27%
==========================================================
Files 35 36 +1
Lines 1944 1991 +47
Branches 555 579 +24
==========================================================
+ Hits 1760 1808 +48
+ Misses 181 180 -1
Partials 3 3
☔ View full report in Codecov by Sentry. |
joelvdavies
force-pushed
the
view-systems-#18
branch
from
November 1, 2023 12:58
cc646c3
to
ea31ee0
Compare
joshuadkitenge
previously approved these changes
Nov 9, 2023
joelvdavies
dismissed
joshuadkitenge’s stale review
November 10, 2023 08:23
The base branch was changed.
joshuadkitenge
approved these changes
Nov 10, 2023
This was referenced Jan 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds navigation, progress bars and displays information about the selected system
e.g.
Where things are optional, they just display None when not defined. Also made a task for #116.
The create dialog's importance drop down has also been modified to display chips similarly.
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
Closes #18