Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uppy refresh token logic #1152

Merged
merged 7 commits into from
Jan 14, 2025
Merged

Conversation

joshuadkitenge
Copy link
Collaborator

Description

  • Fix existing code so it use relevant api client instead of imsApi
  • refactor thumbnail view logic to use displayed images
  • remove upload error uppy event listener as it not needed as backend deals with image errors
  • create uppy uppyOnBeforeRequest function that set the auth headers
  • create uppyOnAfterResponse to deal with 403 errors

Testing instructions

  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

closes #1147

- Fix existing code so it use relevant api client instead of imsApi
- refactor thumbnail view logic to use displayed images
- remove upload error uppy event listener as it not needed as backend
  deals with image errors
- create uppy uppyOnBeforeRequest function that set the auth headers
- create uppyOnAfterResponse to deal with 403 errors
src/api/api.tsx Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 34.14634% with 27 lines in your changes missing coverage. Please review.

Project coverage is 98.96%. Comparing base (017b068) to head (2de9a9e).
Report is 82 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/api/api.tsx 18.18% 27 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1152      +/-   ##
===========================================
- Coverage    99.10%   98.96%   -0.15%     
===========================================
  Files           94       94              
  Lines        17527    17563      +36     
  Branches      2978     2981       +3     
===========================================
+ Hits         17370    17381      +11     
- Misses         153      178      +25     
  Partials         4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshuadkitenge
Copy link
Collaborator Author

remove timeout

@joshuadkitenge joshuadkitenge changed the base branch from develop to refactor/thumbnail-view-logic January 2, 2025 16:41
@joshuadkitenge joshuadkitenge marked this pull request as ready for review January 3, 2025 10:06
Base automatically changed from refactor/thumbnail-view-logic to develop January 6, 2025 13:58
Copy link
Collaborator

@joelvdavies joelvdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked well for me.

@joshuadkitenge joshuadkitenge merged commit d03524a into develop Jan 14, 2025
6 of 7 checks passed
@joshuadkitenge joshuadkitenge deleted the api-refresh-logic-uppy-#1147 branch January 14, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use API refresh logic on image upload
2 participants