Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nested routes for admin page #1211 #1212

Merged
merged 11 commits into from
Jan 9, 2025

Conversation

joshuadkitenge
Copy link
Collaborator

@joshuadkitenge joshuadkitenge commented Dec 19, 2024

Description

  • Use proper routing for admin home , unit and usage status

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage
  • {more steps here}

Agile board tracking

closes #1211

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.14%. Comparing base (41d0568) to head (eedfab6).
Report is 15 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1212      +/-   ##
===========================================
+ Coverage    99.13%   99.14%   +0.01%     
===========================================
  Files           92       93       +1     
  Lines        17655    17644      -11     
  Branches      2958     2954       -4     
===========================================
- Hits         17503    17494       -9     
+ Misses         148      146       -2     
  Partials         4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshuadkitenge joshuadkitenge force-pushed the nested-routes-for-manufacturers-#1154 branch from 4ace2d9 to b8a0d23 Compare December 20, 2024 18:57
@joshuadkitenge joshuadkitenge force-pushed the nested-routes-for-admin-page-#1211 branch from 3290ea2 to c48ffc9 Compare January 6, 2025 12:19
@joshuadkitenge joshuadkitenge changed the base branch from nested-routes-for-manufacturers-#1154 to handle-404-errors-with-react-router-manufacturers January 8, 2025 10:21
- Updated `src/App.tsx` to integrate BaseLayout headers.
- Modified `src/admin/adminLayout.component.tsx` to use BaseLayout headers.
- Updated tests and snapshots to reflect the changes.
@joshuadkitenge joshuadkitenge marked this pull request as ready for review January 8, 2025 11:24
Base automatically changed from handle-404-errors-with-react-router-manufacturers to develop January 8, 2025 13:39
src/admin/adminCardView.component.tsx Outdated Show resolved Hide resolved
src/admin/adminCardView.component.tsx Outdated Show resolved Hide resolved
src/admin/adminLayout.component.tsx Outdated Show resolved Hide resolved
src/admin/adminCardView.component.tsx Outdated Show resolved Hide resolved
@joshuadkitenge joshuadkitenge force-pushed the nested-routes-for-admin-page-#1211 branch from e24c5d5 to ab3c84a Compare January 8, 2025 16:07
- manufacturer loader in the correct location
- Add scroll restoration react router
- add dev tool for react query
@joshuadkitenge joshuadkitenge force-pushed the nested-routes-for-admin-page-#1211 branch from ab3c84a to df29caf Compare January 8, 2025 16:31
src/App.tsx Outdated Show resolved Hide resolved
@joshuadkitenge joshuadkitenge merged commit ae52c7f into develop Jan 9, 2025
6 checks passed
@joshuadkitenge joshuadkitenge deleted the nested-routes-for-admin-page-#1211 branch January 9, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nested routes for admin page
2 participants