-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nested routes for admin page #1211 #1212
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1212 +/- ##
===========================================
+ Coverage 99.13% 99.14% +0.01%
===========================================
Files 92 93 +1
Lines 17655 17644 -11
Branches 2958 2954 -4
===========================================
- Hits 17503 17494 -9
+ Misses 148 146 -2
Partials 4 4 ☔ View full report in Codecov by Sentry. |
joshuadkitenge
force-pushed
the
nested-routes-for-manufacturers-#1154
branch
from
December 20, 2024 18:57
4ace2d9
to
b8a0d23
Compare
…es-for-admin-page-#1211
joshuadkitenge
force-pushed
the
nested-routes-for-admin-page-#1211
branch
from
January 6, 2025 12:19
3290ea2
to
c48ffc9
Compare
joshuadkitenge
changed the base branch from
nested-routes-for-manufacturers-#1154
to
handle-404-errors-with-react-router-manufacturers
January 8, 2025 10:21
Base automatically changed from
handle-404-errors-with-react-router-manufacturers
to
develop
January 8, 2025 13:39
joelvdavies
reviewed
Jan 8, 2025
joshuadkitenge
force-pushed
the
nested-routes-for-admin-page-#1211
branch
from
January 8, 2025 16:07
e24c5d5
to
ab3c84a
Compare
- manufacturer loader in the correct location - Add scroll restoration react router - add dev tool for react query
joshuadkitenge
force-pushed
the
nested-routes-for-admin-page-#1211
branch
from
January 8, 2025 16:31
ab3c84a
to
df29caf
Compare
joelvdavies
reviewed
Jan 9, 2025
joelvdavies
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
closes #1211