Handle 404 errors with react router systems #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1231 +/- ##
===========================================
+ Coverage 99.11% 99.13% +0.02%
===========================================
Files 94 94
Lines 17641 17658 +17
Branches 2130 2953 +823
===========================================
+ Hits 17485 17506 +21
+ Misses 155 148 -7
- Partials 1 4 +3 ☔ View full report in Codecov by Sentry. |
…with-react-router-systems
…with-react-router-systems
joshuadkitenge
force-pushed
the
nested-routes-for-system-#1213
branch
from
27c551f to
b6345f9
Compare
…with-react-router-systems
…with-react-router-systems
…with-react-router-systems
joshuadkitenge
force-pushed
the
nested-routes-for-system-#1213
branch
from
9fe5a77 to
2101f0c
Compare
…with-react-router-systems
joelvdavies
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BaseLayout is implement in this pr #1217
Testing instructions
Add a set up instructions describing how the reviewer should test the code