Nested routes for catalogue #1218 #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated catalogue categories and items Cypress tests - Refactored App.tsx to support nested routes - Updated admin card view snapshot tests - Modified API endpoints for catalogue categories and items - Added new components and tests for catalogue layout and items - Removed obsolete catalogue component and tests - Updated error page and tab view tests - Refactored items components and tests
- Fixed failing tests in catalogue and items components - Refactored code to address bugs found in various components - Updated snapshots for catalogue layout and items page
…d-routes-for-catalogue-#1218
joshuadkitenge
changed the base branch from
develop
to
handle-404-errors-with-react-router-systems
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## develop #1232 +/- ##
===========================================
+ Coverage 99.10% 99.11% +0.01%
===========================================
Files 94 96 +2
Lines 17527 17549 +22
Branches 2978 2993 +15
===========================================
+ Hits 17370 17394 +24
+ Misses 153 151 -2
Partials 4 4 ☔ View full report in Codecov by Sentry. |
Base automatically changed from
handle-404-errors-with-react-router-systems
to
develop
January 9, 2025 12:09
joelvdavies
reviewed
Jan 9, 2025
src/catalogue/items/__snapshots__/catalogueItemsDetailsPanel.component.test.tsx.snap
Outdated
Show resolved
Hide resolved
src/catalogue/items/__snapshots__/catalogueItemsPage.component.test.tsx.snap
Outdated
Show resolved
Hide resolved
src/catalogue/__snapshots__/catalogueContainer.component.test.tsx.snap
Outdated
Show resolved
Hide resolved
joshuadkitenge
force-pushed
the
nested-routes-for-catalogue-#1218
branch
from
5620460 to
f1a7689
Compare
joelvdavies
reviewed
Jan 9, 2025
joshuadkitenge
commented
Jan 9, 2025
joelvdavies
previously approved these changes
Jan 10, 2025
joshuadkitenge
force-pushed
the
fix-flaky-test
branch
from
df8b1d4 to
26519ad
Compare
joshuadkitenge
force-pushed
the
fix-flaky-test
branch
from
26519ad to
e93044b
Compare
joelvdavies
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing instructions
Agile board tracking
closes #1218