-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve route for home page #1233 #1234
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuadkitenge
force-pushed
the
nested-routes-for-catalogue-#1218
branch
from
January 9, 2025 13:44
5620460
to
f1a7689
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #1234 +/- ##
========================================
Coverage 99.11% 99.11%
========================================
Files 96 96
Lines 17549 17563 +14
Branches 2993 2994 +1
========================================
+ Hits 17394 17408 +14
- Misses 151 154 +3
+ Partials 4 1 -3 ☔ View full report in Codecov by Sentry. |
joelvdavies
previously approved these changes
Jan 10, 2025
joshuadkitenge
dismissed
joelvdavies’s stale review
January 13, 2025 12:49
The base branch was changed.
joelvdavies
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This needs to be done as all declared routes on scigateway needs to have there 404n managed by the plugin
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
closes #1233