Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve route for home page #1233 #1234

Merged
merged 10 commits into from
Jan 13, 2025

Conversation

joshuadkitenge
Copy link
Collaborator

Description

This needs to be done as all declared routes on scigateway needs to have there 404n managed by the plugin

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage
  • {more steps here}

Agile board tracking

closes #1233

@joshuadkitenge joshuadkitenge force-pushed the nested-routes-for-catalogue-#1218 branch from 5620460 to f1a7689 Compare January 9, 2025 13:44
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.11%. Comparing base (df22100) to head (05dad65).
Report is 13 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1234   +/-   ##
========================================
  Coverage    99.11%   99.11%           
========================================
  Files           96       96           
  Lines        17549    17563   +14     
  Branches      2993     2994    +1     
========================================
+ Hits         17394    17408   +14     
- Misses         151      154    +3     
+ Partials         4        1    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshuadkitenge joshuadkitenge marked this pull request as ready for review January 10, 2025 13:36
joelvdavies
joelvdavies previously approved these changes Jan 10, 2025
Base automatically changed from nested-routes-for-catalogue-#1218 to develop January 13, 2025 12:49
@joshuadkitenge joshuadkitenge dismissed joelvdavies’s stale review January 13, 2025 12:49

The base branch was changed.

@joshuadkitenge joshuadkitenge merged commit 5cbd5b2 into develop Jan 13, 2025
7 checks passed
@joshuadkitenge joshuadkitenge deleted the improve-route-for-home-page-#1233 branch January 13, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve route for home page
2 participants