-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the 404 page to match scigateway #1237 #1238
Improve the 404 page to match scigateway #1237 #1238
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #1238 +/- ##
=========================================
Coverage 99.11% 99.11%
=========================================
Files 96 97 +1
Lines 17563 17610 +47
Branches 2994 2184 -810
=========================================
+ Hits 17408 17455 +47
Misses 154 154
Partials 1 1 ☔ View full report in Codecov by Sentry. |
…-page-to-match-scigateway-#1237
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Single comment, looks good.
Description
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
closes #1237