Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the 404 page to match scigateway #1237 #1238

Merged

Conversation

joshuadkitenge
Copy link
Collaborator

Description

  • Create pageNotFound
  • Apply for all 404 pages

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage
  • {more steps here}

Agile board tracking

closes #1237

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.11%. Comparing base (05dad65) to head (c886478).
Report is 14 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop    #1238    +/-   ##
=========================================
  Coverage    99.11%   99.11%            
=========================================
  Files           96       97     +1     
  Lines        17563    17610    +47     
  Branches      2994     2184   -810     
=========================================
+ Hits         17408    17455    +47     
  Misses         154      154            
  Partials         1        1            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshuadkitenge joshuadkitenge marked this pull request as ready for review January 10, 2025 13:37
Copy link
Collaborator

@joelvdavies joelvdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single comment, looks good.

src/admin/adminLayout.component.tsx Outdated Show resolved Hide resolved
Base automatically changed from improve-route-for-home-page-#1233 to develop January 13, 2025 13:24
@joshuadkitenge joshuadkitenge merged commit 76241fd into develop Jan 13, 2025
7 checks passed
@joshuadkitenge joshuadkitenge deleted the improve-the-404-page-to-match-scigateway-#1237 branch January 13, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the 404 page to match scigateway
2 participants