Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node-version on CI to 22 #1243

Closed
wants to merge 1 commit into from
Closed

Conversation

joelvdavies
Copy link
Collaborator

Description

Noticed on #1239. Should match the production version used in the dockerfile at least in major version.

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

Copy link

codecov bot commented Jan 13, 2025

❌ 13 Tests Failed:

Tests completed Failed Passed Skipped
710 13 697 1
View the top 3 failed tests by shortest run time
src/catalogue/catalogue.component.test.tsx > Catalogue > opens copy catalogue category dialog and can close the dialog
Stack Traces | 5.04s run time
Error: Test timed out in 5000ms.
If this is a long-running test, pass a timeout value as the last argument or configure it globally with "testTimeout".
src/systems/systemItemsDialog.component.test.tsx > SystemItemsDialog > Move to > moves selected systems (to non-root system)
Stack Traces | 5.47s run time
Error: Test timed out in 5000ms.
If this is a long-running test, pass a timeout value as the last argument or configure it globally with "testTimeout".
src/catalogue/catalogue.component.test.tsx > Catalogue > selects and deselects catalogue categories
Stack Traces | 5.61s run time
Error: Test timed out in 5000ms.
If this is a long-running test, pass a timeout value as the last argument or configure it globally with "testTimeout".

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@joelvdavies
Copy link
Collaborator Author

Closing for now as significantly slower, will be instead addressed in #1244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant