Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented logic to show total row count on tables #441 #466

Merged
merged 33 commits into from
May 20, 2024

Conversation

MatteoGuarnaccia5
Copy link
Contributor

@MatteoGuarnaccia5 MatteoGuarnaccia5 commented Mar 28, 2024

Description

Added text to show total rows on table and what rows are being shown in the current table state

Testing instructions

  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

closes #441

src/utils.tsx Outdated Show resolved Hide resolved
@MatteoGuarnaccia5 MatteoGuarnaccia5 marked this pull request as ready for review April 3, 2024 13:27
Copy link
Collaborator

@joelvdavies joelvdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might also be worth adding something like this for the subsystems table/the catalogue categories page.

@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 98.95833% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 94.55%. Comparing base (5d87c74) to head (b934dcd).
Report is 36 commits behind head on develop.

Files Patch % Lines
src/systems/systems.component.tsx 93.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #466      +/-   ##
===========================================
+ Coverage    94.08%   94.55%   +0.46%     
===========================================
  Files           63       64       +1     
  Lines        17863    19402    +1539     
  Branches      2438     2701     +263     
===========================================
+ Hits         16807    18345    +1538     
- Misses        1050     1051       +1     
  Partials         6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joelvdavies
Copy link
Collaborator

It now overlaps if there are more pages/the count is larger e.g.
image

I think its worth getting it to work with xs={12} sm={6} on the two columns so it displays on two separate lines if its smaller e.g.
image
It didn't work properly with just that change as I also had to set the card view height to 0px again. It also likely needs usage of a breakpoint to do this to change the justifyContent in the grid for the pagingation e.g.

sx={(theme) => ({
    [theme.breakpoints.up('sm')]: { justifyContent: 'flex-end' },
})}

@joelvdavies
Copy link
Collaborator

It now overlaps if there are more pages/the count is larger e.g. image

I think its worth getting it to work with xs={12} sm={6} on the two columns so it displays on two separate lines if its smaller e.g. image It didn't work properly with just that change as I also had to set the card view height to 0px again. It also likely needs usage of a breakpoint to do this to change the justifyContent in the grid for the pagingation e.g.

sx={(theme) => ({
    [theme.breakpoints.up('sm')]: { justifyContent: 'flex-end' },
})}

I think I have improved the behaviour in the latest commit.

@MatteoGuarnaccia5 MatteoGuarnaccia5 merged commit 1262c7c into develop May 20, 2024
4 checks passed
@MatteoGuarnaccia5 MatteoGuarnaccia5 deleted the show-total-rows-on-tables-#441 branch May 20, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change tables to show the total number of rows
4 participants