Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use replica set for MongoDB in e2e api tests on CI #499 #500

Merged
merged 4 commits into from
Apr 25, 2024

Conversation

joelvdavies
Copy link
Collaborator

@joelvdavies joelvdavies commented Apr 15, 2024

Description

Uses script added in ral-facilities/inventory-management-system-api#236.

Once ral-facilities/inventory-management-system-api#236 is merged the branch being pulled will be changed to develop.

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

Closes #499

@joelvdavies joelvdavies added enhancement Improved or refactored feature MVP labels Apr 15, 2024
@joelvdavies joelvdavies self-assigned this Apr 15, 2024
@joelvdavies joelvdavies force-pushed the use-replica-set-#499 branch from 37f061f to d24b1aa Compare April 15, 2024 13:48
@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.97%. Comparing base (914c35f) to head (dbb7fea).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #500   +/-   ##
========================================
  Coverage    93.97%   93.97%           
========================================
  Files           62       62           
  Lines        17663    17663           
  Branches      2385     2385           
========================================
  Hits         16599    16599           
  Misses        1058     1058           
  Partials         6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joelvdavies joelvdavies force-pushed the use-replica-set-#499 branch 2 times, most recently from db677da to d055835 Compare April 15, 2024 15:46
@joelvdavies joelvdavies marked this pull request as ready for review April 25, 2024 10:10
@joelvdavies joelvdavies force-pushed the use-replica-set-#499 branch 2 times, most recently from 6bffa3c to 6dbab35 Compare April 25, 2024 15:53
@joelvdavies joelvdavies force-pushed the use-replica-set-#499 branch from 6dbab35 to 031032c Compare April 25, 2024 15:56
@joelvdavies joelvdavies merged commit 01da656 into develop Apr 25, 2024
4 checks passed
@joelvdavies joelvdavies deleted the use-replica-set-#499 branch April 25, 2024 16:09
@joelvdavies joelvdavies mentioned this pull request May 17, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improved or refactored feature MVP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use replica set in e2e api tests
3 participants