Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed table to use system name and not id #497 #505

Merged
merged 10 commits into from
May 7, 2024

Conversation

MatteoGuarnaccia5
Copy link
Contributor

Description

Changed items table to display system name rather than system ID.
System objects are fetched from backend from set of system IDs - set of IDs is created from items data

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

closes #497

@MatteoGuarnaccia5 MatteoGuarnaccia5 marked this pull request as ready for review April 18, 2024 08:50
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.06%. Comparing base (646631d) to head (42d5129).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #505      +/-   ##
===========================================
+ Coverage    94.03%   94.06%   +0.02%     
===========================================
  Files           62       62              
  Lines        17712    17793      +81     
  Branches      2044     2403     +359     
===========================================
+ Hits         16656    16737      +81     
+ Misses        1054     1050       -4     
- Partials         2        6       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@joelvdavies joelvdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments. Also could you update the landing pages and detail panels to use system name as well please.

I also noticed that navigating using the system name link from the items table to a systems page causes
image

src/items/__snapshots__/itemsTable.component.test.tsx.snap Outdated Show resolved Hide resolved
src/items/itemsTable.component.tsx Outdated Show resolved Hide resolved
@joshuadkitenge
Copy link
Collaborator

Can the system be grouped by the system id and not the name please

Copy link
Collaborator

@joelvdavies joelvdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MatteoGuarnaccia5 MatteoGuarnaccia5 merged commit f835645 into develop May 7, 2024
4 checks passed
@MatteoGuarnaccia5 MatteoGuarnaccia5 deleted the replace-system-id-with-name-#497 branch May 7, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to using System name instead of system id
4 participants