Ids catalogue properties #515 #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #516 +/- ##
===========================================
+ Coverage 93.98% 94.06% +0.07%
===========================================
Files 62 63 +1
Lines 17700 17782 +82
Branches 2389 2076 -313
===========================================
+ Hits 16636 16726 +90
+ Misses 1058 1054 -4
+ Partials 6 2 -4 ☔ View full report in Codecov by Sentry. |
joshuadkitenge
commented
Apr 24, 2024
.github/workflows/ci-build.yml
Outdated
| @@ -82,7 +82,7 @@ jobs: | |||
| MONGO_INITDB_ROOT_PASSWORD: example | |||
|
|
|||
| ims-api: | |||
| image: harbor.stfc.ac.uk/inventory-management-system/ims-api:develop | |||
| image: harbor.stfc.ac.uk/inventory-management-system/ims-api:pr-240 | |||
There was a problem hiding this comment.
Suggested change
| image: harbor.stfc.ac.uk/inventory-management-system/ims-api:pr-240 | |
| image: harbor.stfc.ac.uk/inventory-management-system/ims-api:develop |
joshuadkitenge
requested review from
joelvdavies,
VKTB and
MatteoGuarnaccia5
and removed request for
VKTB and
MatteoGuarnaccia5
Merged
3 tasks
joelvdavies
reviewed
Apr 25, 2024
Co-authored-by: Joel Davies <[email protected]>
Co-authored-by: Joel Davies <[email protected]>
* develop: Update dependency eslint-plugin-cypress to v3 Update tanstack-query monorepo to v5.31.0 Update actions/setup-python action to v5.1.0 Update actions/checkout digest Fix connection after changing backend docker compose to host networking #499 Use develop branch for dev cli script Update dependency material-react-table to v2.13.0 Use dev_cli script from api to setup the database for e2e api tests #499
|
the e2e tests are failing because the backend hasn't been merged in |
joelvdavies
previously approved these changes
Apr 30, 2024
joelvdavies
force-pushed
the
ids-catalogue-properties-#515
branch
from
56b61ef to
6a0a71f
Compare
joelvdavies
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
closes #515