Delete a catalogue item #8 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuadkitenge
changed the base branch from
develop
to
landing-pages-catelogue-items-#69
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #77 +/- ##
========================================
Coverage 87.73% 87.74%
========================================
Files 28 29 +1
Lines 1019 1093 +74
Branches 290 305 +15
========================================
+ Hits 894 959 +65
- Misses 124 133 +9
Partials 1 1
☔ View full report in Codecov by Sentry. |
…gue-item-#8 * landing-pages-catelogue-items-#69: add manufacturer details to the landing page #69 fix e2e test add error checking for URL add manufacturer details in the view catalogue items #66 manufacturer details in the add catalogue item add e2e test for edit catalogue category from a leaf node to a non - leaf add better checking for catalogue properties and invalidate queries for the catalogueCategory list and getById (patch and post queries) #38 Fix loading screen issue on firefox
…gue-item-#8 * landing-pages-catelogue-items-#69: Update dependency @types/node to v18 fix unit test stop getById triggering when catalogue category is deleted refactor if statement for boolean values address review comments Update tanstack-query monorepo to v4.35.7 Update dependency axios to v1.5.1 address review comments Update actions/cache digest to 704facf Update actions/upload-artifact action to v3 Update actions/setup-node action to v3 Update dependency eslint-plugin-prettier to v5 Update dependency @types/jest to v29 Update codecov/codecov-action action to v3 Update dependency eslint-config-prettier to v8.9.0 Update dependency @testing-library/jest-dom to v5.17.0
joelvdavies
requested changes
Oct 18, 2023
There was a problem hiding this comment.
Just two minor suggestions. Obviously waiting on ral-facilities/inventory-management-system-api#81 as well.
Co-authored-by: Joel Davies <[email protected]>
joelvdavies
previously approved these changes
Oct 18, 2023
|
Just for reference, I get |
|
Could we modify the logic of the fix so msw runs when process.env.REACT_APP_E2E_TESTING as well regardless of the apiUrl? Right now I have to modify my config before running the tests or they will fail. |
joelvdavies
approved these changes
Oct 20, 2023
VKTB
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A user should be able to delete a catalogue item using bin icon on the respective row.
Testing instructions
Test that it deletes successfully and renders correct after deletion
Review code
Check Actions build
Review changes to test coverage
{more steps here}
Agile board tracking
closes #8