Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manufacturers #68 #80

Merged
merged 17 commits into from
Nov 8, 2023
Merged

Add manufacturers #68 #80

merged 17 commits into from
Nov 8, 2023

Conversation

MatteoGuarnaccia5
Copy link
Contributor

@MatteoGuarnaccia5 MatteoGuarnaccia5 commented Sep 28, 2023

Description

Add a manufacturer via a text form, all the fields need to be filled and there is relevant error checks (for invalid urls and duplicate names as well)

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage
  • test adding and also using invalid url, empty strings(spaces) =

Agile board tracking

closes #68

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (9688e29) 89.33% compared to head (d0da1e6) 88.81%.

❗ Current head d0da1e6 differs from pull request most recent head 92ae589. Consider uploading reports for the commit 92ae589 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #80      +/-   ##
===========================================
- Coverage    89.33%   88.81%   -0.53%     
===========================================
  Files           32       31       -1     
  Lines         1519     1466      -53     
  Branches       461      433      -28     
===========================================
- Hits          1357     1302      -55     
- Misses         159      161       +2     
  Partials         3        3              
Files Coverage Δ
src/app.types.tsx 100.00% <ø> (ø)
src/manufacturer/manufacturerDialog.component.tsx 100.00% <100.00%> (ø)
src/api/manufacturer.tsx 87.09% <94.11%> (+8.52%) ⬆️
src/manufacturer/manufacturer.component.tsx 88.88% <83.33%> (-11.12%) ⬇️
src/mocks/handlers.ts 93.96% <75.00%> (-3.50%) ⬇️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MatteoGuarnaccia5 MatteoGuarnaccia5 changed the base branch from develop to view-manufacturers-#74 October 10, 2023 09:40
@MatteoGuarnaccia5 MatteoGuarnaccia5 marked this pull request as ready for review October 17, 2023 15:24
@joshuadkitenge joshuadkitenge requested review from joelvdavies and removed request for joshuadkitenge November 6, 2023 09:58
Copy link
Collaborator

@joelvdavies joelvdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, doesn't work on the current branch of additional-manufacturer-details on the api though as the postCode name needs changing to postcode. May also be worth merging the latest view-manufacturers in as the branch its based on is quite old.

cypress/e2e/manufacturer/manufacturer.cy.tsx Outdated Show resolved Hide resolved
src/app.types.tsx Outdated Show resolved Hide resolved
src/manufacturer/AddmanufacturerDialog.component.test.tsx Outdated Show resolved Hide resolved
src/manufacturer/manufacturerDialog.component.tsx Outdated Show resolved Hide resolved
src/mocks/handlers.ts Outdated Show resolved Hide resolved
Base automatically changed from view-manufacturers-#74 to develop November 7, 2023 10:46
Copy link
Collaborator

@joelvdavies joelvdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of things I noticed - With the exception of the missing grid elements (and console.log), I am happy for the other changes to be addressed in #112 if you prefer.

src/app.types.tsx Show resolved Hide resolved
src/app.types.tsx Show resolved Hide resolved
src/manufacturer/manufacturerDialog.component.tsx Outdated Show resolved Hide resolved
src/manufacturer/manufacturerDialog.component.tsx Outdated Show resolved Hide resolved
src/manufacturer/manufacturerDialog.component.tsx Outdated Show resolved Hide resolved
src/api/manufacturer.tsx Show resolved Hide resolved
@joelvdavies joelvdavies self-requested a review November 7, 2023 16:25
Copy link
Collaborator

@joelvdavies joelvdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be merged with #80.

@MatteoGuarnaccia5 MatteoGuarnaccia5 merged commit 1b205cb into develop Nov 8, 2023
1 check passed
@MatteoGuarnaccia5 MatteoGuarnaccia5 deleted the add-manufacturers-#68 branch November 8, 2023 10:07
@joelvdavies joelvdavies mentioned this pull request Nov 9, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As an operator/admin, I want to be able to add manufacturers
3 participants