-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add manufacturers #68 #80
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #80 +/- ##
===========================================
- Coverage 89.33% 88.81% -0.53%
===========================================
Files 32 31 -1
Lines 1519 1466 -53
Branches 461 433 -28
===========================================
- Hits 1357 1302 -55
- Misses 159 161 +2
Partials 3 3
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, doesn't work on the current branch of additional-manufacturer-details on the api though as the postCode
name needs changing to postcode
. May also be worth merging the latest view-manufacturers in as the branch its based on is quite old.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of things I noticed - With the exception of the missing grid elements (and console.log), I am happy for the other changes to be addressed in #112 if you prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be merged with #80.
Description
Add a manufacturer via a text form, all the fields need to be filled and there is relevant error checks (for invalid urls and duplicate names as well)
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
closes #68