Apply changes from OG Vite migration #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #817 +/- ##
===========================================
+ Coverage 99.15% 99.23% +0.08%
===========================================
Files 72 72
Lines 16041 16075 +34
Branches 2978 2361 -617
===========================================
+ Hits 15905 15952 +47
+ Misses 135 122 -13
Partials 1 1 ☔ View full report in Codecov by Sentry. |
joelvdavies
force-pushed
the
apply-changes-from-OG-vite
branch
3 times, most recently
from
bdf61b3 to
01d4550
Compare
joelvdavies
force-pushed
the
apply-changes-from-OG-vite
branch
from
01d4550 to
4de65f6
Compare
joelvdavies
force-pushed
the
apply-changes-from-OG-vite
branch
from
f23d929 to
09f44c7
Compare
|
Should only be merged after ral-facilities/operationsgateway#421 is in case any more changes come up. |
joshuadkitenge
requested changes
Sep 6, 2024
joshuadkitenge
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applies tweaks found while doing the OG Vite migration. Likely want the same changes on SciGateway's Vite branch too.
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking