-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
investigate release notes automation #962
base: develop
Are you sure you want to change the base?
investigate release notes automation #962
Conversation
Feature/test feature
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #962 +/- ##
========================================
Coverage 99.13% 99.13%
========================================
Files 89 89
Lines 17572 17572
Branches 2130 2129 -1
========================================
Hits 17420 17420
Misses 151 151
Partials 1 1 ☔ View full report in Codecov by Sentry. |
be3d822
to
aa9f382
Compare
aa9f382
to
066d066
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only looked at the branch names, had some thoughts, happy to discuss further.
security: | ||
- head-branch: ['^security/'] | ||
documentation: | ||
- head-branch: ['^documentation/'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these work with multiple? Could docs/documentation
work for example? I personally prefer docs but then some others can't be shortened.
Same for feat/feature.
Thinking about it, perhaps its worth aligning closer with https://www.conventionalcommits.org/en/v1.0.0/ (This is what DAFNI used, although they are for commits instead)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enhancement: | ||
- head-branch: ['^enhancement/'] | ||
bug: | ||
- head-branch: ['^bug/'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- head-branch: ['^bug/'] | |
- head-branch: ['^fix/'] |
I think the branch names tend to be more to do with that they do, so this is normally fix
.
feature: | ||
- head-branch: ['^feature/'] | ||
dependencies: | ||
- head-branch: ['^dependencies/'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this and dependency
if possible.
dependencies: | ||
- head-branch: ['^dependencies/'] | ||
enhancement: | ||
- head-branch: ['^enhancement/'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following on from these being what they do, perhaps enhance/
? Or even improve/
.
deprecated: | ||
- head-branch: ['^deprecated/'] | ||
removed: | ||
- head-branch: ['^removed/'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- head-branch: ['^removed/'] | |
- head-branch: ['^remove/'] |
Description
Added configuration for custom auto generated release notes.
Made relevant changes in documentation.
The same changes would need to be made in ims-api
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
closes #806