-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add delete endpoint for image #72
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #72 +/- ##
===========================================
+ Coverage 98.29% 98.59% +0.30%
===========================================
Files 21 21
Lines 410 428 +18
===========================================
+ Hits 403 422 +19
+ Misses 7 6 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small comments. will look at the tests afterwards. This PR may have some minor conflicts with the get branch so will probably need merging into to this branch one it is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments works well.
c360d4a
to
094fb83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Implements a DELETE endpoint
/images/<image_id>
that:object_key
doesn't existTesting instructions
Agile board tracking
closes #38