Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSEGOG-361 view all users on admin page #514

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

joshuadkitenge
Copy link
Contributor

@joshuadkitenge joshuadkitenge commented Nov 12, 2024

Description

  • An admin user should be able to view all user on the admin page in scigateway.
  • Material react table is user to display all the users in the admin page
  • React router has been implement for the separate the admin user route at /admin/users

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

closes DSEGOG-361

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 95.58824% with 9 lines in your changes missing coverage. Please review.

Project coverage is 97.82%. Comparing base (e2cbc62) to head (f1ca4cf).

Files with missing lines Patch % Lines
src/admin/users/usersTable.component.tsx 88.88% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #514      +/-   ##
===========================================
- Coverage    97.86%   97.82%   -0.04%     
===========================================
  Files           94       97       +3     
  Lines        12531    12732     +201     
  Branches      2025     2035      +10     
===========================================
+ Hits         12263    12455     +192     
- Misses         266      275       +9     
  Partials         2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Upgrade to use react router 7
- remove password from the mock data
- add pageNotFound
@joshuadkitenge joshuadkitenge force-pushed the DSEGOG-361-view-all-users branch from bdb0d99 to f1ca4cf Compare January 13, 2025 15:41
@joelvdavies joelvdavies mentioned this pull request Jan 17, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant