Search for JS() calls recursively only in explicit lists and data.frames
#467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Names are characters, explicitly cast indices to characters
Fixes #466 Avoids recursion of list-like objects that aren't actually lists. Recursion over data.frames is uncommon but was previously supported and can, in theory, contain `JS()` calls in list columns.
cpsievert
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #466 by avoids recursion of list-like objects that aren't actually lists, as suggested by @DavisVaughn.
Recursion over data.frames is uncommon but was previously supported and list columns can, in theory, contain
JS()code.The core issue from #466 is the assignment of integers to
names(options), which was aclock_calendarobject. Casting to character before assignment is safer, but doesn't completely solve the problem and in fact provides further evidence that we should be more selective about recursion becauescalsis infinitely recusable:In summary, after this change,
shouldEval()only enters explicit lists and data.frames to search forJS()(JS_EVAL) objects.