Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for group_membership_filter in azuread #1458

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bigkevmcd
Copy link

Issue: rancher/rancher#46209

Problem

It's not currently possible to configure the user-group filter from Terraform.

Solution

This adds support for configuring the group_memembership_filter for Azure which configures a filter for querying groups for a user.

Testing

Engineering Testing

Manual Testing

Configured a simple "azuread" resource...

resource "rancher2_auth_config_azuread" "azuread" {
 // other fields omitted for simplicity
  group_membership_filter = "startswith(displayName,'admin')"
}

And confirmed that these are configured on the azuread AuthConfig resource, and that they are updated when changed.

Automated Testing

Tests were added for the new behaviour.

QA Testing Considerations

Regressions Considerations

This adds support for configuring the group_memembership_filter for
Azure which configures a filter for querying groups for a user.
@bigkevmcd bigkevmcd self-assigned this Jan 8, 2025
@bigkevmcd bigkevmcd marked this pull request as draft January 8, 2025 14:15
@bigkevmcd bigkevmcd marked this pull request as ready for review January 9, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant