-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make cugraph-ops optional for cugraph-gnn packages #99
Open
tingyu66
wants to merge
13
commits into
rapidsai:branch-25.02
Choose a base branch
from
tingyu66:rm-cugraph-ops
base: branch-25.02
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+89
−124
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
4f4c82e
make cugraph-ops optional for cugraph-pyg
tingyu66 d3f975a
Merge branch 'branch-25.02' into rm-cugraph-ops
tingyu66 eddabef
Merge branch 'branch-25.02' into rm-cugraph-ops
tingyu66 bafd813
format
tingyu66 a111a09
Merge branch 'branch-25.02' into rm-cugraph-ops
jameslamb 8e5a0f8
pre-commit
tingyu66 4992680
use just pytorch instead of pytorch-gpu
tingyu66 c48941a
update -pyg examples
tingyu66 1120cdb
skip importing convs in cugraph-dgl
tingyu66 0d285e0
Merge branch 'branch-25.02' into rm-cugraph-ops
tingyu66 c4019df
modify conda recipes
tingyu66 be8996f
Merge branch 'branch-25.02' into rm-cugraph-ops
tingyu66 ec9598e
style
tingyu66 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,4 +1,4 @@ | ||||||
# Copyright (c) 2022-2024, NVIDIA CORPORATION. | ||||||
# Copyright (c) 2022-2025, NVIDIA CORPORATION. | ||||||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||||||
# you may not use this file except in compliance with the License. | ||||||
# You may obtain a copy of the License at | ||||||
|
@@ -11,6 +11,7 @@ | |||||
# See the License for the specific language governing permissions and | ||||||
# limitations under the License. | ||||||
|
||||||
import pytest | ||||||
import cudf | ||||||
import cupy as cp | ||||||
import numpy as np | ||||||
|
@@ -179,6 +180,7 @@ def test_get_source_destination_range(): | |||||
assert output_d == expected_output | ||||||
|
||||||
|
||||||
@pytest.mark.skip(reason="Skipping due to missing cugraph-ops backend.") | ||||||
def test__create_homogeneous_cugraph_dgl_nn_sparse_graph(): | ||||||
tensor_d = { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: Looks like a typo with the double underscore here.
Suggested change
|
||||||
"sources_range": 1, | ||||||
|
@@ -196,6 +198,7 @@ def test__create_homogeneous_cugraph_dgl_nn_sparse_graph(): | |||||
assert isinstance(sparse_graph, cugraph_dgl.nn.SparseGraph) | ||||||
|
||||||
|
||||||
@pytest.mark.skip(reason="Skipping due to missing cugraph-ops backend.") | ||||||
def test_create_homogeneous_sampled_graphs_from_dataframe_csc(): | ||||||
df = get_dummy_sampled_df_csc() | ||||||
batches = create_homogeneous_sampled_graphs_from_dataframe_csc(df) | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the dependencies in the conda recipes be removed as well?
cugraph-gnn/conda/recipes/cugraph-pyg/meta.yaml
Line 38 in 71675d8
cugraph-gnn/conda/recipes/cugraph-dgl/meta.yaml
Line 32 in 71675d8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tingyu66 could you please make this change (removing the dependencies on
pylibcugraphops
in conda recipes) in this PR?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jameslamb Done, thank you!