Refactor MG Centrality Tests #4197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nv-rliu
added
improvement
nv-rliu
force-pushed
the
b2404-cleanup-mg-tests
branch
from
9f792d4 to
73840cd
Compare
nv-rliu
force-pushed
the
b2404-cleanup-mg-tests
branch
from
39cb5f6 to
b3ec32c
Compare
|
Some unrelated tests are failing and I'm currently investigating/reproducing this locally. |
nv-rliu
force-pushed
the
b2404-cleanup-mg-tests
branch
from
7ec59c8 to
0513b81
Compare
nv-rliu
force-pushed
the
b2404-cleanup-mg-tests
branch
from
eaeec44 to
39a4e97
Compare
rlratzel
reviewed
Mar 14, 2024
python/cugraph/cugraph/tests/centrality/test_betweenness_centrality_mg.py
Show resolved
Hide resolved
acostadon
approved these changes
Mar 14, 2024
python/cugraph/cugraph/tests/centrality/test_betweenness_centrality_mg.py
Show resolved
Hide resolved
rlratzel
approved these changes
Mar 14, 2024
2 tasks
jnke2016
approved these changes
Mar 14, 2024
|
/merge |
rapids-bot
bot
merged commit fa096f0
into
rapidsai:branch-24.04
137 of 138 checks passed
rapids-bot bot
pushed a commit
that referenced
this pull request
May 14, 2024
Addresses #4187 This PR makes improvements to old MG testing conventions used in these testing directories: - centrality - comms - community - components - core - internals The goals of this PR is to improve readability and use of the MG tests. Changes are similar to #4197 > Instead of using nested fixtures. eg. `input_expected_output -> input_combo -> fixture_params` which can be confusing, the `@pytest.mark.parametrize` marker is used to iterate through combinations of parameters used for testing. The fixtures are also replaced by functions used to create SG and MG graphs. By using the Datasets API (which now supports MG Graphs thanks to @huiyuxie), the number of imports and `testing.utils` functions can be significantly reduced. Authors: - Ralph Liu (https://github.com/nv-rliu) Approvers: - Rick Ratzel (https://github.com/rlratzel) URL: #4244
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #4187
This PR makes improvements to old testing conventions used in
cugraph.centralityMG testsInstead of using nested fixtures. eg.
input_expected_output -> input_combo -> fixture_paramswhich can be confusing, the@pytest.mark.parametrizemarker is used to iterate through combinations of parameters used for testing. The fixtures are also replaced by functions used to create SG and MG graphs.