Skip to content

Commit

Permalink
Use rapids-cmake for the logger (#6205)
Browse files Browse the repository at this point in the history
This PR switches cuml to use rapids-cmake to fetch rapids-logger so that
it uses a consistent version with the rest of RAPIDS to avoid any cases
where transitive CPM loads result in multiple packages being built from
source that require a different version of rapids-logger.

Depends on rapidsai/raft#2534.

Contributes to rapidsai/build-planning#104.
  • Loading branch information
vyasr authored Jan 6, 2025
1 parent 51e6851 commit e0e16ca
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -231,11 +231,8 @@ endif()
rapids_cpm_init()
rapids_cmake_install_lib_dir(lib_dir)

# Not using rapids-cmake since we never want to find, always download.
CPMAddPackage(
NAME rapids_logger GITHUB_REPOSITORY rapidsai/rapids-logger GIT_SHALLOW FALSE GIT_TAG
4df3ee70c6746fd1b6c0dc14209dae2e2d4378c6 VERSION 4df3ee70c6746fd1b6c0dc14209dae2e2d4378c6
)
include(${rapids-cmake-dir}/cpm/rapids_logger.cmake)
rapids_cpm_rapids_logger()
rapids_make_logger(
ML EXPORT_SET cuml-exports LOGGER_HEADER_DIR include/cuml/common/ LOGGER_MACRO_PREFIX CUML LOGGER_TARGET cuml_logger
)
Expand Down

0 comments on commit e0e16ca

Please sign in to comment.