Futher tweaks

rapidsai · Nov 15, 2024 · 0725d63 · 0725d63
1 parent 1852545
commit 0725d63
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 3 deletions.
diff --git a/cpp/include/kvikio/defaults.hpp b/cpp/include/kvikio/defaults.hpp
@@ -235,7 +235,7 @@ class defaults {
       static auto inferred_compat_mode_for_auto = []() -> CompatMode {
         return is_cufile_available() ? CompatMode::OFF : CompatMode::ON;
       }();
-      compat_mode = inferred_compat_mode_for_auto;
+      return inferred_compat_mode_for_auto;
     }
     return compat_mode;
   }

diff --git a/cpp/include/kvikio/file_handle.hpp b/cpp/include/kvikio/file_handle.hpp
@@ -126,7 +126,7 @@ class FileHandle {
    * @brief Get the underlying cuFile file handle
    *
    * The file handle must be open and not in compatibility mode i.e.
-   * both `.closed()` and `defaults::can_compat_mode_reduce_to_on()` must be return false.
+   * both `.closed()` and `defaults::can_compat_mode_reduce_to_on()` must be false.
    *
    * @return cuFile's file handle
    */

diff --git a/cpp/tests/test_defaults.cpp b/cpp/tests/test_defaults.cpp
@@ -38,7 +38,7 @@ TEST(Defaults, parse_compat_mode_str)
   }
 
   {
-    std::vector<std::string> inputs{"AUTO", "auto", "aUtO"};
+    std::vector<std::string> inputs{"AUTO", "auto", "aUtO", "WHATEVER", "whatever", "WhatEver"};
     for (const auto& input : inputs) {
       EXPECT_EQ(kvikio::detail::parse_compat_mode_str(input), kvikio::CompatMode::AUTO);
     }

diff --git a/python/kvikio/tests/test_defaults.py b/python/kvikio/tests/test_defaults.py
@@ -19,6 +19,8 @@ def test_compat_mode():
         assert kvikio.defaults.compat_mode() == kvikio.CompatMode.ON
         kvikio.defaults.compat_mode_reset(kvikio.CompatMode.OFF)
         assert kvikio.defaults.compat_mode() == kvikio.CompatMode.OFF
+        kvikio.defaults.compat_mode_reset(kvikio.CompatMode.AUTO)
+        assert kvikio.defaults.compat_mode() == kvikio.CompatMode.AUTO
     assert before == kvikio.defaults.compat_mode()