Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S3 support #426
S3 support #426
Changes from 12 commits
32130c2
4a5884c
804fd99
bbbe637
a752eee
ce4218a
5ba191d
5126b44
185e687
502f7cf
740a15d
7fbabdf
5b41e74
555903d
69f7fd9
39ca408
cce5b1b
1c601ad
551fe20
b0ff3d1
afb2dae
06c0311
504f15d
2de3486
5f07f2e
f391ad1
247ab4d
9adffc1
8b4436d
2287c9b
e830f62
bff52a4
f6e7ebc
3f8291a
2607ca1
6f3c25d
149d6be
98991b3
daac52f
ba6925c
c635519
b8bfef2
4c4b36e
e489bbe
73d9104
b4ac1d7
d9ba372
146efc0
b19a146
4cb54a9
379f521
8849d11
8c54a6c
bb0ad24
33b9227
2e5ff0b
378e9b6
496fe8d
ea2d93c
3bb3ce1
b9b2c44
fa4f298
c483b68
ce0c59a
bbb4042
f363f15
8129d17
37b294c
fb95490
2729dbf
ce08365
e800233
a60011a
0d68e49
72812cc
c4ccd9e
4f765d0
355d192
500681a
d2a49c9
bd83655
2687cc6
8fe82b9
fdb9a59
4e4389f
cebc0a8
61a5d50
d55030a
2123666
0c2f09b
bb445a3
4701b52
2bd411e
b40a0ad
7bcfe5b
2a9f934
b978323
00304e7
f9b49f2
0403686
0001265
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Perhaps not for this prototype, but if it is easy, perhaps yes.
Should building S3 support be a user-configurable option. That is, even if we can find the package, should we have an option (say
-DKVIKIO_HAVE_S3_SUPPORT=1
) to cmake so that the user can compile without this dependency if they are only doing local I/O?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, done