Stop tagging wheels as arch-agnostic #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since rapidsai#479, the libkvikio wheel now includes platform-specific files. Stop tagging the wheel as "any".
KyleFromNVIDIA
added
bug
bdice
approved these changes
Oct 23, 2024
|
/merge |
|
Is this really what we want here? Should the libkvikio wheel actually contain libcurl builds, or should that all be set up as part of its interface so that something building against libkvikio will build curl? If the current build behavior is desirable, we should run auditwheel to get the wheels tagged as manylinux wheels. If the current behavior is not desirable, we need to update the build system so that libcurl is not built as part of the C++. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #479, the libkvikio wheel now includes platform-specific files. Stop tagging the wheel as "any".