remove cython dependency, remove setup.cfg #10
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came here looking to remove the
setup.cfg
file, inspired by rapidsai/raft#2532.But this PR uncovered a few other packaging things to be cleaned up. Proposes:
Cython
dependencycmake_minimum_required()
version with the one from the conda recipe, and with what RAPIDS has been using for the last few releasesmaptlolib
dependency for benchmarksNotes for Reviewers
How is it safe to remove
Cython
?As far as I can tell, this project doesn't have any Cython code. It is building a shared library and then loading it with
ctypes
:legate-raft/legate_raft/library.py
Lines 21 to 26 in 3260952