Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to effet 3.10 #720

Merged
merged 7 commits into from
Nov 10, 2024

Conversation

titouancreach
Copy link
Contributor

@titouancreach titouancreach commented Oct 21, 2024

Effect has updated to 3.10 merging @effect/schema into effect main package.

https://effect.website/blog/effect-3.10

So this PR, remove @effect/schema, change the imports and update effect.

btw it deprecates: #710

@titouancreach
Copy link
Contributor Author

titouancreach commented Oct 24, 2024

pretty sure there is something to change here too:

"build:effect-ts": "microbundle --cwd effect-ts --globals @hookform/resolvers=hookformResolvers,react-hook-form=ReactHookForm,@effect/schema=EffectSchema,@effect/schema/AST=EffectSchemaAST,@effect/schema/ArrayFormatter=EffectSchemaArrayFormatter,@effect/schema/ParseResult=EffectSchemaArrayFormatter,effect/Effect=Effect",

@charlee-dev
Copy link

also, you can try to bump it to 3.10.2 instead, as they had another update last night

@akoenig
Copy link
Contributor

akoenig commented Oct 25, 2024

@titouancreach I contributed a PR back to your fork with the update of the microbundle task and an update to the most recent version of Effect.

@titouancreach
Copy link
Contributor Author

titouancreach commented Oct 28, 2024

@akoenig great !! can you make a PR on my fork 🙃 So we don't loose the commit history
Thanks!!

titouancreach and others added 2 commits October 28, 2024 09:42
@dudeofawesome
Copy link
Contributor

I've created a PR to bring the last of my changes from #710 that didn't make it into this PR.

@titouancreach
Copy link
Contributor Author

Thanks @dudeofawesome !

@akoenig
Copy link
Contributor

akoenig commented Oct 30, 2024

Don't want to sound pushy, but is there any chance to get this PR merged? Effect is moving pretty fast and this PR is blocking me from updating to Effect 3.10 – I'm afraid of getting behind the schedule and therefore having a large migration effort in the future.

@titouancreach
Copy link
Contributor Author

@akoenig I don't know if it helps, but this resolver only consist in two files, I simply copy pasted it to my code waiting for this PR to be merged, so my code don't stay behind

@dudeofawesome
Copy link
Contributor

dudeofawesome commented Oct 30, 2024

@akoenig I've also got a version based on my old PR published on NPM, which I've been using to keep up with Effect.

You can use it pretty seamlessly by simply updating your package.json to point to my package instead, allowing you to keep your imports the same.

{
  ...
  "dependencies": {
    "@hookform/resolvers": "npm:@dudeofawesome/[email protected]"
  }
}

@bluebill1049 bluebill1049 mentioned this pull request Nov 7, 2024
@bluebill1049 bluebill1049 merged commit e523dde into react-hook-form:master Nov 10, 2024
4 checks passed
@lauren-inato
Copy link

@bluebill1049 any idea when this will be released?

@jonathanpowers-storable
Copy link
Contributor

Ah, so

  • This repo uses semantic-release, which expects one changelog entry per commit
  • The latest commit started with chore:
  • The commits were squashed, leaving the final commit message as the only one seen by semantic-release

Led to semantic-release ignoring that commit
image

We need to push another commit that starts with one of the correct triggers like feat: or fix: for it to cut a new release. The content of the commit does not matter.

@bluebill1049 @vinassefranche Do you want me to come up with an insignificant commit that meets the above criteria, or is there some other way you'd like to handle this?

@vinassefranche
Copy link

@jonathanpowers-storable thanks for the detailed info!
I'm not a maintainer of the repo so I'm not sure I have my voice on this but if you can push a commit that would trigger the release of a new version, it would be amazing!

Copy link
Contributor

github-actions bot commented Jan 6, 2025

🎉 This PR is included in version 3.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants