Validate bufferSize and prefetch bounds - #4315
Open
DragonFSKY wants to merge 1 commit into
Open
DragonFSKY wants to merge 1 commit into
DragonFSKY wants to merge 1 commit into
Conversation
Values greater than 1 << 30 can overflow Queues.ceilingNextPowerOfTwo and lead to negative array capacities. Validate these arguments before queue or array allocation. Keep Integer.MAX_VALUE as the existing unbounded sentinel for queue-backed prefetch operators. Fixes reactor#4273. Signed-off-by: Dongliang Xie <dragonfsky@gmail.com>
DragonFSKY
force-pushed
the
4273-validate-buffer-prefetch
branch
from
August 25, 2026 12:52
507484a to
91eae54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Values greater than
1 << 30overflow the internal power-of-two capacity calculation. This change validatesfilterWhenbuffer sizes and queue-backed prefetch values before allocation, while preservingInteger.MAX_VALUEas the existing unbounded prefetch sentinel.The affected public operators have focused boundary coverage, including the preserved unbounded behavior.
Verification:
./gradlew :reactor-core:test --no-daemon./gradlew spotlessCheck --no-daemonFixes #4273.