Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mobile toolkit v3 URL helper #139

Merged
merged 15 commits into from
Dec 16, 2024
Merged

Add mobile toolkit v3 URL helper #139

merged 15 commits into from
Dec 16, 2024

Conversation

chocolatkey
Copy link
Member

@chocolatkey chocolatkey commented Oct 9, 2024

This ports the kotlin-toolkit's V3 update's URL helper classes, to replace the current ones, which resolves #90

Other changes made include:

  • Replace the mobile toolkits' custom implementation of URI templates with a more complete third-party implementation, which helps with service link matching
  • Add the ManifestTransformer functionality from the mobile toolkit
  • Moved to using native mediatypes instead of mime strings across the codebase, and added a few necessary helper functions
  • Fix OPUS mimetype
  • Implement the missing Locator Text.Substring function
  • Added URL schemes, with support for cloud protocols, in preparation for cloud streaming

@chocolatkey chocolatkey marked this pull request as ready for review December 9, 2024 07:00
Copy link
Member

@mickael-menu mickael-menu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, that looks much cleaner! 👍

pkg/manifest/locator.go Outdated Show resolved Hide resolved
pkg/parser/epub/parser_navdoc.go Outdated Show resolved Hide resolved
pkg/util/url/url.go Outdated Show resolved Hide resolved
pkg/util/url/url.go Outdated Show resolved Hide resolved
pkg/util/url/url.go Outdated Show resolved Hide resolved
Copy link
Member

@mickael-menu mickael-menu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes 🙏

@mickael-menu mickael-menu merged commit b997dc7 into develop Dec 16, 2024
4 checks passed
@mickael-menu mickael-menu deleted the new-url-helpers branch December 16, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove leading slashes from relative HREFs
2 participants