Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re #29 but partially addresses it, more has to be done on Actions branch given the extent of the Setting component refactoring.
This should already help with most issues, inspired from the React Aria Components’ own styles so that should be OK, a11y-wise.
focus
seems to be handled programmatically.That was tested on a large amount of actual devices using BrowserStack but of course that doesn’t mean you may encounter issues.
Known edge cases:
Escape
Key or clicking the close button usingEnter/Space
Keys, the focus ring will be visible in immersive mode. First click will dismiss it, second will toggle immersive. It’s not necessarily a rare occurrence as one might use a mouse to click actions and menus, andEscape
to close them – some sort of hybrid use.There’s no simple/trivial solution to this given how complex focus management becomes at this point, with multiple factors to take into account, so it will be preferable to address this in Actions – with this PR merged into it.