Sheets #51
Draft
Sheets #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Takes the number of items per row to infer which one to select and focus, but it pretty much overrides the React Aria component default so things may be missing currently, it has to be stress-tested a11y-wise.
This is stolen by themes anyway, but opens a can of worms as themes will steal the focus as a side effect of opening settings, even if it’s not the first section in the sheet.
You can set a default for all actions, then override it either for all breakpoints, or per breakpoint for each action
For RSPrefs, as their name is tied to this key, so using the prop directly could cause issues further down the line.
Deploying playground with
|
| Latest commit: |
0c1b6c2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0d9a6947.playground-7xz.pages.dev |
| Branch Preview URL: | https://sheets.playground-7xz.pages.dev |
If selected not found, fall back on close button
And Reorg/rename styles
Let’s now focus on docking options
|
@bluefirepatrick thanks for the review. And sorry for the lack of commits in the last days as I've been neck-deep in redesigning docked sheets so that:
While implementing resizability it became clear the current approach based on positioning couldn't perform well. And to be honest it also creates unnecessary complexity to handle the preference. Hopefully I should have something better by the start of next week. |
To prevent circular references and errors
This was referenced Jan 14, 2025
Docking is now handled in reducers, with global states, and less complexity. Panels are now collapsible as a side effect of React portal requiring a DOM element to render the docked sheet. Docking is now direction-agnostic and takes RTL into account
Several issues to fix though, including arrows on hover + tap/click and immersive mode set to false
Yeah so no, given the current status of this project, and what exists for React web, there’s not much else to do than creating our own component. Sigh.
So that it’s easier for components to know what’s open and docked. + OverflowMenu was a global state for all overflow menus. Now they are handled as their own object.
Except NextJS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes care of #12, so expect things to change dramatically while this is in Draft as we’ll have to build custom components to implement all types listed in the issue. Due to holidays, things should move a little bit slower though.
At this stage, focus was on #41 and #47 in order to init things.
At the time of drafting, the following has been worked on to build the foundations of this epic:
PopoverSheetandFullscreenSheetcomponents – which are currently more like templates to help test other things listed, hence minimal styling, etc.;SheetWithBreakpointscomponent that should help pick the type of sheet based on the static breakpoints set in Preferences;To illustrate/test the
SheetWithBreakpointscomponent, Settings is usingfullscreenincompactandmedium, thenpopover(default) fromexpanded.Alias for deploy to latest commit: sheets.playground-7xz.pages.dev