fix: remove redundant check related to option(_) labelled props #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchavarri
reviewed
Oct 20, 2023
anmonteiro
force-pushed
the
anmonteiro/rm-untrue-check
branch
2 times, most recently
from
dfeed60 to
cbab933
Compare
anmonteiro
changed the title
|
@jchavarri added tests and re-ordered the commits to show how the check was redundant. |
anmonteiro
force-pushed
the
anmonteiro/rm-untrue-check
branch
from
cbab933 to
342a6b7
Compare
anmonteiro
force-pushed
the
anmonteiro/rm-untrue-check
branch
from
342a6b7 to
4721911
Compare
jchavarri
approved these changes
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this check is necessary anymore, since #776 and #791.
After those PRs we infer the types correctly for optionally labelled arguments.