Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pipeablestream to new lib #815

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Move pipeablestream to new lib #815

merged 2 commits into from
Nov 7, 2023

Conversation

jchavarri
Copy link
Collaborator

Fixes #814.

Adds a new library reason-react.node-only that only includes the binding to renderToPipeableStream and companion types and utilities.

Copy link
Member

@davesnx davesnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM probably reason-react.node looks good too!

@jchavarri jchavarri merged commit 6938d62 into main Nov 7, 2023
3 checks passed
@jchavarri jchavarri deleted the fix-814 branch November 7, 2023 10:30
@anmonteiro
Copy link
Member

Why don't we make ReactDOMServer itself the entire separate library?

@anmonteiro
Copy link
Member

Check #819 with a proposal.

I'm not a big fan of node-only since that also works in deno, bun, other runtimes.

Instead, my proposal separates the entire ReactDOMServer module to a new reason-react.dom-server library.

Let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundling errors in ES6 due to react-dom having different API in Node and browser
3 participants