Repository navigation
Use the new updater - #3250
Merged
Merged
Use the new updater#3250
Conversation
fire-light42
approved these changes
Oct 11, 2026
fire-light42
left a comment
Collaborator
There was a problem hiding this comment.
The markdown parsing is not very robust, but it is sufficient for updates. I would recommend updating (creating tests) it if its used to render user-provided text (plugins).
Otherwise everything looks good and works well. The only foreseeable issue is constant update popups if we delete a version (since its a mismatch).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This searches for updates using the new updater, as well as moves the viewmodel to the shared scope. '
Unfortunately kotlin is a bit weird about val on data classes in a different project, so the old code actually gives error if we move it without
val dialog = updaterState.dialog.