Repository navigation
Cap removed-API rules at upper version bound - #798
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several version-bound rules migrate off a PHPUnit API that was hard-removed in a known major. Past removal + 2 majors the legacy source can no longer exist in runnable code, so keeping these rules active on every file is cost with no value. Matches the existing upper-bound pattern already used on ExplicitPhpErrorApiRector and TestListenerToHooksRector.
Adds an upper bound to each, using removal major + 2:
Removal majors verified against the PHPUnit ChangeLog-6.0 / 9.0 / 10.0 Removed sections.
Each rule gets a test composer.json stub pinning phpunit inside the capped range plus a provideComposerJsonFilePath() override, so the rules stay active under test.
Left uncapped (no source API removal, modernization only): GetMockBuilderGetMockToCreateMockRector, AssertRegExpRector, RemoveDataProviderTestPrefixRector, AddDoesNotPerformAssertionToNonAssertingTestRector.