Repository navigation
[perf] Speed up CodingStyle rules with cheap guards before type lookup, reflection and regex - #8669
Merged
Merged
Conversation
…p, reflection and regex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance refactor of 3 rules. No behavior change - all fixtures pass unchanged.
StrictInArrayRector- the first argument native type is now resolved only after the second argument is confirmed to be an array, so a non-array second argument skips onegetNativeType()call.UseClassKeywordForClassNameResolutionRector- the cheapstr_contains($name, "\\")check now runs insidegetExistingClasses()beforereflectionProvider->hasClass(), so short non-namespaced matches skip the reflection lookup. The separatefilterOurShortClasses()pass that removed them afterwards is now redundant and removed.SimplifyQuoteEscapeRector- a string with no quote characters now bails beforehasNonPrintableChars()(two regex matches plus a unicode check), using the already-computedsubstr_count()values.Reordering is safe: all moved checks are side-effect-free bail conditions, and the removed filter was the only consumer of the short-name exclusion it duplicated.