Repository navigation
[Visibility] Speed up ChangeConstantVisibilityRector with cheap constant-name gate before type resolution - #8673
Merged
Merged
Conversation
…ant-name gate before type resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same perf pattern as #8655. The rule fires on every
Class_/Interface_node and loops over all configuredChangeConstantVisibilityentries, callingisObjectType()on each before the cheap constant-name match happens in the nested loop.isObjectType()resolves the node type via the uncachedgetType(), so for K config entries the class type is resolved K times per node, even for entries whose target constant the class does not declare.This adds a cheap constant-name gate: collect the class constant names once (plain AST), and skip an entry before
isObjectType()when the class has no constant of that name. The gate mirrorsisNamesemantics onClassConstexactly - first declared const per statement, lowercased to match the case-insensitivestrcasecmp- so it can only false-positive (then the existing innerisNameloop rejects as before), never false-negative. Behavior is identical.Tests, ECS and PHPStan pass locally.